Add missing import extension, check with lint #4795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: a6667cd The changes in this PR will be included in the next version bump. This PR includes changesets to release 29 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
glasser
force-pushed
the
glasser/fix-esm-imports
branch
from
a4002e6 to
37be731
Compare
Some pure-ESM processors (eg, `tsc` with `moduleResolution: 'nodenext') require extensions on all imports. ardatan#4778 added two import-less extensions. This PR fixes them and adds linting (from an already-installed plugin) to catch future errors. Test execution does not appear to require these extensions so we only check non-test files (there's another 17 errors to fix if you want to check tests too).
glasser
force-pushed
the
glasser/fix-esm-imports
branch
from
37be731 to
a6667cd
Compare
|
The failing tests appear to be memory issues and I can't imagine that they are caused by this PR. Since the issue breaks certain builds it would be great if this could be released quickly after merging! |
|
@B2o5T Could you review eslint rules? |
dimaMachina
approved these changes
Oct 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚨 IMPORTANT: Please do not create a Pull Request without creating an issue first.
Any change needs to be discussed before proceeding. Failure to do so may result in the rejection of the pull request.
This is a build regression from #4778. I can file an issue if you really want me to.
Description
Some pure-ESM processors (eg,
tscwith `moduleResolution: 'nodenext') require extensions on all imports. #4778 added two import-less extensions. This PR fixes them and adds linting (from an already-installed plugin) to catch future errors. Test execution does not appear to require these extensions so we only check non-test files (there's another 17 errors to fix if you want to check tests too).While this requirement isn't documented anywhere I found quickly, I have to assume it's intentional (since #4539) because every other import uses it.
Type of change
Please delete options that are not relevant.
Screenshots/Sandbox (if appropriate/relevant):
n/a
How Has This Been Tested?
#4778 (specifically,
@graphql-tools/[email protected]broke a build in my project.The breakage pointed directly at these two lines.
The lint rule I added also found only these two lines. So I fixed them. I have not yet actually verified that the built package fixes my original problem, but it sure seems likely.
Checklist:
Further comments
Pretty simple I hope.