Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow return type specification in IFieldResolver #968

Merged
merged 5 commits into from
Apr 23, 2020
Merged

Allow return type specification in IFieldResolver #968

merged 5 commits into from
Apr 23, 2020

Conversation

oscarnylander
Copy link
Contributor

@oscarnylander oscarnylander commented Oct 7, 2018

  • This adds a fourth parameter to IFieldResolver: TReturn
  • TReturn defaults to any for backwards compatibility

Relates to #704

TODO:

  • If this PR is a new feature, reference an issue where a consensus about the design was reached (not necessary for small changes)
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass
  • Update CHANGELOG.md with your change. Include a description of your change, link to PR (always) and issue (if applicable). Add your CHANGELOG entry under vNEXT. Do not create a new version number for your change yourself.

- This adds a fourth parameter to `IFieldResolver`: `TReturn`
- TReturn defaults to `any` for backwards compatibility
@apollo-cla
Copy link

@hedvigoscar: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

@ghost ghost added the feature New addition or enhancement to existing solutions label Oct 7, 2018
@mfix22 mfix22 requested a review from hwillson October 24, 2018 20:59
@mfix22 mfix22 requested a review from benjamn as a code owner November 30, 2018 00:19
@mfix22 mfix22 self-assigned this Nov 30, 2018
@mfix22
Copy link
Contributor

mfix22 commented Jan 11, 2019

@hedvigoscar are you able to get this PR up to date with master?

@oscarnylander
Copy link
Contributor Author

@mfix22 Should be good now I think 👍

@mfix22
Copy link
Contributor

mfix22 commented Jan 11, 2019

@hwillson just wanted to confirm with you before merging since I haven't updated the types before 👍

@ericbiewener
Copy link

Any update on this? Seems like a desirable addition.

@hwillson hwillson removed their request for review April 8, 2020 11:53
@ardatan
Copy link
Owner

ardatan commented Apr 23, 2020

Thanks @hedvigoscar !

@ardatan ardatan merged commit a50cf53 into ardatan:master Apr 23, 2020
@oscarnylander
Copy link
Contributor Author

🙇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New addition or enhancement to existing solutions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants