Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Safer implementation of no-SNI connection method #24

Merged
merged 1 commit into from
May 28, 2020
Merged

Safer implementation of no-SNI connection method #24

merged 1 commit into from
May 28, 2020

Conversation

manchoz
Copy link
Contributor

@manchoz manchoz commented May 18, 2020

Alternative implementation for #19.

@endorama please, review.

aentinger
aentinger approved these changes May 25, 2020
View reviewed changes
Copy link
Contributor

@aentinger aentinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good morning @manchoz 👋 I certainly approve, I think you can't make the danger signs any bigger 😉

@manchoz
Copy link
Contributor Author

manchoz commented May 25, 2020

I was wondering it was too small! ;-)

@aentinger aentinger merged commit be4f5b4 into arduino-libraries:master May 28, 2020
endorama
endorama reviewed Jun 1, 2020
View reviewed changes
Copy link

@endorama endorama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change! LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@endorama endorama endorama left review comments

@aentinger aentinger aentinger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@manchoz @endorama @aentinger