Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Service query is overflowing #8

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Luftzig
Copy link

@Luftzig Luftzig commented Jul 24, 2020

by sending the length the header instead of the just 4 needed bytes.
See #7

@CLAassistant
Copy link

CLAassistant commented Apr 9, 2021

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Yoav Luft seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@gigaj0ule
Copy link

gigaj0ule commented Jun 20, 2022

This PR fixes a critical bug!

Without it we get weird buffer overruns in the processing logic that cause malformed packets.

@agdl, @marqdevx, does this library have any maintainers?

If not you can add me as one and I will upstream this as well as try to merge the sensible future commits from trippylightning's branch.

@per1234 per1234 added type: imperfection Perceived defect in any part of project topic: code Related to content of the project itself labels Jun 23, 2022
@per1234 per1234 linked an issue Feb 23, 2023 that may be closed by this pull request
@zyphlar
Copy link

zyphlar commented Apr 27, 2024

Removing a call to addServiceRecord made this library way more reliable for me @aentinger

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Service query message sends some junk
5 participants