Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add specifier to generated tool property keys #165

Closed
wants to merge 2 commits into from

Conversation

facchinm
Copy link
Member

@facchinm facchinm commented Jul 4, 2016

port of arduino/Arduino#4795 to golang
should solve arduino/Arduino#5042

This is far less powerful than Java version since the tools are not tangled with json package_index but all the information are extracted from the folder name.
Since the folder name only has a "vendor" subpath we cannot correlate the tools with the required version but only try to match the architecture being compiled with the tool vendor.

@ArduinoBot
Copy link
Contributor

✅ Build completed.

⬇️ Build URL: http://downloads.arduino.cc/PR/arduino-builder/arduino-builder-165.zip

ℹ️ To test this build:

  1. Replace arduino-builder binary (you can find it where you installed the IDE) with the provided one

@agdl
Copy link
Member

agdl commented Jul 4, 2016

👍 Working with red bear labs hardware installed!

@facchinm
Copy link
Member Author

facchinm commented Jul 7, 2016

This PR breaks 4 tests (TestSetupBuildProperties, TestSetupBuildPropertiesWithMissingPropsFromParentPlatformTxtFiles, TestLoadTools, TestLoadLotsOfTools).
They are not really "broken" but the folder structure of downloaded_tools doesn't match board manager's so the builtin tools are now "visible", while they were hidden by downloaded_tools before.
This could be a problem when updating AVR core with new tools (arduino/Arduino#5021) on older IDEs

@matthijskooijman @cmaglie , any idea on how we can solve this in a sane way (without parsing package_index json, which would be the best option in the long term)?

@ArduinoBot
Copy link
Contributor

✅ Build completed.

⬇️ Build URL: http://downloads.arduino.cc/PR/arduino-builder/arduino-builder-165.zip

ℹ️ To test this build:

  1. Replace arduino-builder binary (you can find it where you installed the IDE) with the provided one

@facchinm
Copy link
Member Author

facchinm commented Aug 2, 2016

Superseded by arduino/Arduino#5199

@facchinm facchinm closed this Aug 2, 2016
@cmaglie cmaglie added this to the 1.3.20 milestone Aug 3, 2016
@cmaglie cmaglie deleted the duplicate_tools_resolver branch January 11, 2018 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants