Skip to content

Commit

Permalink
[skip changelog] Enable Codecov comments on PRs from forks (#1819)
Browse files Browse the repository at this point in the history
Versions of the `codecov/codecov-action` GitHub Actions action prior to 1.0.6 required the use of a token provided by
Codecov in order to upload data to Codecov. This token was stored in secret in the Arduino CLI repository and used in
the test workflow.

For security reasons, secrets are not accessible when a workflow is triggered by an event generated by a fork of the
repository. This meant that it was impossible to upload coverage data for the test runs triggered by PRs from forks. A
conditional was added to the upload step of the workflow to cause it to only run on `push` event triggers, which
effectively prevented its failure for runs on PRs from forks.

The token requirement was removed in the 1.0.6 release of `codecov/codecov-action`, but the now pointless conditional
was never removed from the workflow. This prevented PRs from forks from receiving the automated code coverage report
comments that would otherwise encourage those contributors to resolve coverage deficiencies and facilitate the review
process.

The harmful conditional is hereby removed from the coverage data upload steps of the workflow and PRs from forks will
now receive coverage report comments, just as PRs from branches do already.
  • Loading branch information
per1234 authored Aug 1, 2022
1 parent 5332ffd commit a55df0d
Showing 1 changed file with 2 additions and 6 deletions.
8 changes: 2 additions & 6 deletions .github/workflows/test-go-task.yml
Original file line number Diff line number Diff line change
Expand Up @@ -98,19 +98,15 @@ jobs:
run: task test-legacy

- name: Send unit tests coverage to Codecov
if: >
runner.os == 'Linux' &&
github.event_name == 'push'
if: runner.os == 'Linux'
uses: codecov/codecov-action@v3
with:
file: ./coverage_unit.txt
flags: unit
fail_ci_if_error: ${{ github.repository == 'arduino/arduino-cli' }}

- name: Send legacy tests coverage to Codecov
if: >
runner.os == 'Linux' &&
github.event_name == 'push'
if: runner.os == 'Linux'
uses: codecov/codecov-action@v3
with:
file: ./coverage_legacy.txt
Expand Down

0 comments on commit a55df0d

Please sign in to comment.