Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The M1 macOS build artifact should follow the Arduino asset naming convention #2117

Closed
3 tasks done
kittaakos opened this issue Jun 27, 2023 · 1 comment
Closed
3 tasks done
Assignees
Labels
architecture: arm Specific to ARM host architecture conclusion: invalid Issue/PR not valid os: macos Specific to macOS operating system topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project

Comments

@kittaakos
Copy link
Contributor

kittaakos commented Jun 27, 2023

Describe the problem

The following artifacts do not follow the asset naming convention.

should be arduino-ide_2.1.0_macOS_ARM64.dmg and arduino-ide_2.1.0_macOS_ARM64.zip

To reproduce

The IDE2 artifact naming convention follows the convention used by the Arduino CLI, LS, FW Uploader, etc.

Expected behavior

The IDE2 assets follow the Arduino asset naming convention.

Arduino IDE version

2.1

Operating system

macOS

Operating system version

13.4.1

Additional context

The M1 build is manual.

Issue checklist

  • I searched for previous reports in the issue tracker
  • I verified the problem still occurs when using the latest nightly build
  • My report contains all necessary details
@kittaakos kittaakos added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project labels Jun 27, 2023
kittaakos pushed a commit that referenced this issue Jul 3, 2023
 - Use `ARM64` instead of `arm64` on Linux and macOS.
 - Switched from `armv7` to `ARMv7` on Linux.

 Closes #2117

Signed-off-by: Akos Kitta <[email protected]>
@per1234 per1234 added architecture: arm Specific to ARM host architecture os: macos Specific to macOS operating system labels Jul 13, 2023
@per1234 per1234 self-assigned this Oct 6, 2023
@per1234
Copy link
Contributor

per1234 commented Oct 6, 2023

Unfortunately this won't be possible because the use of the exact arm64 architecture identifier in the artifact filename is hardcoded into electron-updater:

https://github.com/electron-userland/electron-builder/blob/7704be02a076ec51a5bf118f59c0d47927b5c85f/packages/electron-updater/src/MacUpdater.ts#L67

    const isArm64 = (file: ResolvedUpdateFileInfo) => file.url.pathname.includes("arm64") || file.info.url?.includes("arm64")
    if (isArm64Mac && files.some(isArm64)) {
      files = files.filter(file => isArm64Mac === isArm64(file))
    } else {
      files = files.filter(file => !isArm64(file))
    }

In fact we had the ARM64 identifier originally: f6275f9 and it had to be changed to the current arm64 identifier because it caused the incorrect version of Arduino IDE to be installed on update. There is a more detailed explanation in the PR for that bug fix: #1919

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
architecture: arm Specific to ARM host architecture conclusion: invalid Issue/PR not valid os: macos Specific to macOS operating system topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Development

No branches or pull requests

2 participants