Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adjust to new debug -I -P format in #41

Merged
merged 2 commits into from
Dec 13, 2023
Merged

feat: adjust to new debug -I -P format in #41

merged 2 commits into from
Dec 13, 2023

Conversation

kittaakos
Copy link
Contributor

@kittaakos kittaakos commented Oct 26, 2023 •
edited
Loading

  • Adapt the debug launch config generation to the new CLI debug --info --programmer output,
  • Split up the extension code into modules,
  • Fixed security warnings,
  • Added integration tests,
  • Update CI workflow,
  • Generate schema and types for cortex-debug,
  • Validate debug_custom.json.

@kittaakos kittaakos changed the title feat: adjust to new debug -I format in feat: adjust to new debug -I -P format in Oct 31, 2023
@kittaakos kittaakos mentioned this pull request Oct 31, 2023
Merged
6 tasks
@kittaakos kittaakos force-pushed the cli-0.35.0-rc.1 branch 2 times, most recently from 5dd78be to 6a74472 Compare November 13, 2023 09:31
@kittaakos kittaakos mentioned this pull request Nov 13, 2023
Merged
4 tasks
@kittaakos kittaakos marked this pull request as ready for review November 13, 2023 16:44
@kittaakos kittaakos self-assigned this Nov 13, 2023
@kittaakos kittaakos added type: enhancement Proposed improvement topic: code Related to content of the project itself labels Nov 13, 2023
davegarthsimpson
davegarthsimpson approved these changes Nov 29, 2023
View reviewed changes
Copy link

@davegarthsimpson davegarthsimpson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not see any issues code-wise

feat: adjust to new debug -I format in
a818405 
 - Adapt the debug launch config generation to the new CLI `debug --info --programmer` output,
 - Split up the extension code into modules,
 - Fixed security warnings,
 - Added integration tests,
 - Update CI workflow,
 - Generate schema and types for `cortex-debug`,
 - Validate `debug_custom.json`.

Signed-off-by: Akos Kitta <[email protected]>
chore: update VSIX in Git
01710fc 
Signed-off-by: Akos Kitta <[email protected]>
@kittaakos kittaakos merged commit 9508d0a into main Dec 13, 2023
9 checks passed
@kittaakos kittaakos deleted the cli-0.35.0-rc.1 branch December 13, 2023 13:54
@kittaakos kittaakos mentioned this pull request Dec 13, 2023
Merged
This was referenced Mar 3, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davegarthsimpson davegarthsimpson davegarthsimpson approved these changes

Assignees

@kittaakos kittaakos

Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kittaakos @davegarthsimpson