ADBDEV-6384: Make the tests from allTest more stable #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the next set of circumstances, the test could fail: 1. After restoring the Postgres instance, the recovery process starts. Which calls the asynchronous archive-get. 2. After archive-get checks the existence of the queue directory, but before writing the WAL file, there are restores in the next test is begun. Which leads to the deletion of the queue directory. 3. Since the directory no longer exists, writing the WAL file will fail, and archive-get will write the error file to the queue. 4. A new Postgres instance will start, and the recovery process will begin, which requests the WAL file. 5. The new archive-get looks into the queue directory, finds the error file, and throws out the error, after which the Postgres recovery fails. Because the previous archive-get background process has not finished yet. This patch fixes the problem by using a separate spool directory for each test.
RekGRpth
reviewed
Oct 21, 2024
RekGRpth
reviewed
Nov 6, 2024
RekGRpth
approved these changes
Nov 6, 2024
silent-observer
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the tests from allTest more stable
In the next set of circumstances, the test could fail:
calls the asynchronous archive-get.
writing the WAL file, there are restores in the next test is begun. Which leads
to the deletion of the queue directory.
archive-get will write the error file to the queue.
which requests the WAL file.
throws out the error, after which the Postgres recovery fails. Because the
previous archive-get background process has not finished yet.
This patch fixes the problem by using a separate spool directory for each test.