ADBDEV-6761: Always restore system objects of database #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, when restoring with an empty filter (an empty array), the system catalog was restored only for databases: postgres, template1 and template0. In this case, we cannot get metadata from user databases. Because of this, it was required to first get the OIDs of the user databases and restore again, which is not effective. This patch changes the behavior of the filter to the databases not specified in the filter. The system catalog is now being restored for all databases.
KnightMurloc
changed the title
andr-sokolov
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Always restore system objects of database
Previously, when restoring with an empty filter (an empty array), the system
catalog was restored only for these databases: postgres, template1 and
template0. In this case, we cannot get metadata from user databases. Because of
this, it was required to get the OIDs of the user databases first and restore
again with user databases, whose OIDs had been obtained on the previous step. To
do one step to get metadata about tables instead of these two steps, the system
catalog is restored for all restoring databases.