Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auto compress updated html #22738

Merged

Conversation

ryancdotorg
Copy link
Contributor

Description:

Currently, Tasmota developers need to remember to manually run the script to compress HTML with unishox, due to this being somewhat slow.

This PR adds checks to the process to automatically skip compression for uncompressed files which have not changed, and enables the process by default.

Checklist:

  • The pull request is done against the latest development branch
  • Only relevant files were touched
  • Only one feature/fix was added per PR and the code change compiles without warnings
  • The code change is tested and works with Tasmota core ESP8266 V.2.7.8
  • The code change is tested and works with Tasmota core ESP32 V.3.1.0.241206
  • I accept the CLA.

NOTE: The code change must pass CI tests. Your PR cannot be merged unless tests pass

@Jason2866
Copy link
Collaborator

@s-hadinger @arendst regarding the Platformio implementation it LGTM
unishox is your part ;-)

@s-hadinger
Copy link
Collaborator

This looks good to me. Thanks Ryan

@s-hadinger s-hadinger merged commit dc531de into arendst:development Dec 29, 2024
59 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants