Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TS 5.3 incompatibility #117

Closed
ghoullier opened this issue Nov 21, 2023 · 3 comments · Fixed by #118
Closed

TS 5.3 incompatibility #117

ghoullier opened this issue Nov 21, 2023 · 3 comments · Fixed by #118

Comments

@ghoullier
Copy link

ghoullier commented Nov 21, 2023

Latest version "@arethetypeswrong/cli": "0.13.1" is not compatible with TS5.3

error while checking file:
ts.getResolvedModule is not a function

https://github.com/arethetypeswrong/arethetypeswrong.github.io/blob/main/packages/core/src/internal/checks/internalResolutionError.ts#L28

EDIT: I forked the project to bump typescript and ts-expose-internals to 5.3.2 and it also fails

@markerikson
Copy link

I'm seeing pretty weird behavior on this myself.

Even if I manually run older versions locally, like npx @arethetypeswrong/[email protected] ./package.tgz --format table --ignore-rules false-cjs, I'm still seeing the same error, even though this is the version report:

$ attw --version
cli: v0.1.0
core: v0.1.0
typescript: v5.1.3

@myl7
Copy link

myl7 commented Nov 24, 2023

Related microsoft/rushstack#4404

It seems that although it is a minor update, TS removes the API.
Though it then added an equivalent API, an easy and fast fix is to limit (override should also work) the TS version as ^5.2.2,<5.3.0.

@andrewbranch
Copy link
Collaborator

I was under the impression I had the typescript dependency version pinned in core so I could use internal APIs safely, but I think I messed that up last time I bumped it. Will have a fix out soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants