-
Notifications
You must be signed in to change notification settings - Fork 390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add dataset support to be created using distribution settings #5013
Merged
jfcalvo
merged 12 commits into
feat/add-dataset-automatic-task-distribution
from
feat/create-datasets-with-distribution
Jul 1, 2024
Merged
feat: add dataset support to be created using distribution settings #5013
jfcalvo
merged 12 commits into
feat/add-dataset-automatic-task-distribution
from
feat/create-datasets-with-distribution
Jul 1, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/create-datasets-with-distribution
for more information, see https://pre-commit.ci
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feat/add-dataset-automatic-task-distribution #5013 +/- ##
================================================================================
+ Coverage 91.93% 92.00% +0.06%
================================================================================
Files 135 137 +2
Lines 5818 5905 +87
================================================================================
+ Hits 5349 5433 +84
- Misses 469 472 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…/create-datasets-with-distribution
frascuchon
approved these changes
Jul 1, 2024
…5028) # Description This PR add changes to support update dataset distribution settings. Allowing for example to update `min_submitted` attribute when `overlap` distribution strategy is in use. Closes #5010 **Type of change** (Please delete options that are not relevant. Remember to title the PR according to the type of change) - [ ] Bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] Refactor (change restructuring the codebase without changing functionality) - [ ] Improvement (change adding some improvement to an existing functionality) - [ ] Documentation update **How Has This Been Tested** (Please describe the tests that you ran to verify your changes. And ideally, reference `tests`) - [x] Adding new tests. **Checklist** - [ ] I added relevant documentation - [ ] follows the style guidelines of this project - [ ] I did a self-review of my code - [ ] I made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I filled out [the contributor form](https://tally.so/r/n9XrxK) (see text above) - [ ] I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/) --------- Co-authored-by: Paco Aranda <[email protected]>
jfcalvo
merged commit Jul 1, 2024
f62d58a
into
feat/add-dataset-automatic-task-distribution
14 checks passed
The URL of the deployed environment for this PR is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is the first one related with distribution task feature, adding the following changes:
distribution
JSON column todatasets
table:{"strategy": "overlap", "min_submitted": 1}
.distribution
attribute toDatasetCreate
schema:DatasetOverlapDistributionCreate
withmin_submitted
to1
is used.DatasetOverlapDistributionCreate
only allows values greater or equal than1
formin_submitted
attributed.create_dataset
function is receiving a dictionary instead ofDatasetCreate
schema.DatasetCreateValidator
class.Update of
distribution
attribute for datasets will be done in a different issue.Closes #5005
Type of change
(Please delete options that are not relevant. Remember to title the PR according to the type of change)
How Has This Been Tested
(Please describe the tests that you ran to verify your changes. And ideally, reference
tests
)Checklist