-
Notifications
You must be signed in to change notification settings - Fork 390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPIKE] feat: refresh record count_submitted_responses
column using context functions
#5106
Closed
jfcalvo
wants to merge
20
commits into
feat/add-dataset-automatic-task-distribution
from
feat/refresh-record-count-submitted-responses
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…te schema in datasets context
…e-datasets-distribution
…/create-datasets-with-distribution
for more information, see https://pre-commit.ci
…e-datasets-distribution
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feat/update-datasets-distribution #5106 +/- ##
=====================================================================
+ Coverage 91.98% 91.99% +0.01%
=====================================================================
Files 136 136
Lines 5850 5860 +10
=====================================================================
+ Hits 5381 5391 +10
Misses 469 469
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…/create-datasets-with-distribution
…e-datasets-distribution
…cord-count-submitted-responses
…e-datasets-distribution
…cord-count-submitted-responses
Base automatically changed from
feat/update-datasets-distribution
to
feat/create-datasets-with-distribution
July 1, 2024 10:22
Base automatically changed from
feat/create-datasets-with-distribution
to
feat/add-dataset-automatic-task-distribution
July 1, 2024 10:31
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR include changes to explore the possibility of using a new column named
count_submitted_responses
torecords
table.This new column will be refreshed every time a response is created/updated/deleted maintaining a correct counter value of the submitted responses that a record has.
With this value we can easily filter records that are in
completed
status, using the distribution strategy for the associated dataset.Changes that are included in this PR:
count_submitted_responses
when a response is created/updated/deleted.Changes that are not present in this PR
count_submitted_responses
when responses are created in bulk.count_submitted_responses
when records are created/upserted in bulk.count_submitted_responses
into the search engine mapping.status
to record responses.status
value.Refs #5069
Type of change
(Please delete options that are not relevant. Remember to title the PR according to the type of change)
How Has This Been Tested
(Please describe the tests that you ran to verify your changes. And ideally, reference
tests
)Checklist