Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] argilla: support read draft response models without values #5124

Merged

Conversation

frascuchon
Copy link
Member

@frascuchon frascuchon commented Jun 27, 2024

This PR supports reading responses from the server in a draft status with no values in any of the questions (A clear form). This will be read as no responses in the new SDK (@burtenshaw we should validate this).

Closes #5049

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested

Checklist

  • I added relevant documentation
  • follows the style guidelines of this project
  • I did a self-review of my code
  • I made corresponding changes to the documentation
  • I confirm My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)

@frascuchon frascuchon self-assigned this Jun 28, 2024
@frascuchon frascuchon added this to the v2.0.0 milestone Jun 28, 2024
@frascuchon frascuchon force-pushed the bugfix/support-read-draft-responses-without-values branch from 49fe10f to ea3b53f Compare June 28, 2024 07:05
@frascuchon frascuchon marked this pull request as ready for review June 28, 2024 13:14
Copy link
Member

@nataliaElv nataliaElv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's working! Thanks!

@frascuchon frascuchon merged commit 6372c0b into develop Jul 3, 2024
7 checks passed
@frascuchon frascuchon deleted the bugfix/support-read-draft-responses-without-values branch July 3, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] [SDK] [v2] StopIteration error when retrieving records with existing responses.
3 participants