Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENHANCEMENT] argilla: add record status property #5184

Merged
merged 7 commits into from
Jul 12, 2024
Merged

[ENHANCEMENT] argilla: add record status property #5184

merged 7 commits into from
Jul 12, 2024

Conversation

frascuchon
Copy link
Member

@frascuchon frascuchon commented Jul 9, 2024 •
edited
Loading

Description

This PR adds the record status as a read-only property in the Record resource class.

Closes #5141

Type of change

  • Improvement (change adding some improvement to an existing functionality)

How Has This Been Tested

Checklist

  • I added relevant documentation
  • I followed the style guidelines of this project
  • I did a self-review of my code
  • I made corresponding changes to the documentation
  • I confirm My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)

@frascuchon frascuchon changed the base branch from develop to feat/add-dataset-automatic-task-distribution July 9, 2024 09:20
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 9, 2024

The URL of the deployed environment for this PR is https://argilla-quickstart-pr-5184-ki24f765kq-no.a.run.app

@frascuchon frascuchon linked an issue Jul 9, 2024 that may be closed by this pull request
[TASK] Add status attribute to records #5141
Closed
jfcalvo
jfcalvo approved these changes Jul 10, 2024
View reviewed changes
Copy link
Member

@jfcalvo jfcalvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I have added some comments about code style.

argilla/src/argilla/_models/_record/_record.py Outdated Show resolved Hide resolved
argilla/src/argilla/_models/_record/_record.py Outdated Show resolved Hide resolved
argilla/src/argilla/records/_resource.py Outdated Show resolved Hide resolved
davidberenstein1957
davidberenstein1957 reviewed Jul 10, 2024
View reviewed changes
Copy link
Member

@davidberenstein1957 davidberenstein1957 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small comments here https://github.com/argilla-io/argilla/pull/5184/files#r1671853645

@frascuchon frascuchon merged commit c219764 into feat/add-dataset-automatic-task-distribution Jul 12, 2024
7 checks passed
@frascuchon frascuchon deleted the feat/argilla/add-record-status-property branch July 12, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidberenstein1957 davidberenstein1957 davidberenstein1957 left review comments

@jfcalvo jfcalvo jfcalvo approved these changes

@burtenshaw burtenshaw burtenshaw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[TASK] Add status attribute to records
4 participants
@frascuchon @jfcalvo @burtenshaw @davidberenstein1957