Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add common typing module #1029

Merged
merged 2 commits into from
Oct 9, 2024
Merged

Add common typing module #1029

merged 2 commits into from
Oct 9, 2024

Conversation

plaguss
Copy link
Contributor

@plaguss plaguss commented Oct 9, 2024

Description

Add a new distilabel.typing module to redirect all imports, which simplifies loading variables.

from distilabel.typing import StepColumns, FormattedInput, GenerateOutput

@plaguss plaguss added this to the 1.5.0 milestone Oct 9, 2024
@plaguss plaguss requested a review from gabrielmbmb October 9, 2024 14:05
@plaguss plaguss self-assigned this Oct 9, 2024
Copy link

github-actions bot commented Oct 9, 2024

Documentation for this PR has been built. You can view it at: https://distilabel.argilla.io/pr-1029/

src/distilabel/typing.py Outdated Show resolved Hide resolved
Copy link

codspeed-hq bot commented Oct 9, 2024

CodSpeed Performance Report

Merging #1029 will not alter performance

Comparing common-typing-module (7cb0074) with develop (303722c)

Summary

✅ 1 untouched benchmarks

Co-authored-by: Gabriel Martín Blázquez <[email protected]>
@plaguss plaguss merged commit 106e402 into develop Oct 9, 2024
2 checks passed
@plaguss plaguss deleted the common-typing-module branch October 9, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants