Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix vLLM unload logic when model is None #1080

Merged
merged 5 commits into from
Dec 18, 2024
Merged

Conversation

gabrielmbmb
Copy link
Member

No description provided.

@gabrielmbmb gabrielmbmb added this to the 1.5.0 milestone Dec 18, 2024
@gabrielmbmb gabrielmbmb self-assigned this Dec 18, 2024
Copy link

Documentation for this PR has been built. You can view it at: https://distilabel.argilla.io/pr-1080/

Copy link

codspeed-hq bot commented Dec 18, 2024

CodSpeed Performance Report

Merging #1080 will not alter performance

Comparing fix-vllm-unload (d579382) with develop (cf28976)

Summary

✅ 1 untouched benchmarks

@gabrielmbmb gabrielmbmb merged commit c2ae3f1 into develop Dec 18, 2024
8 checks passed
@gabrielmbmb gabrielmbmb deleted the fix-vllm-unload branch December 18, 2024 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant