-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add load stages #760
Merged
Merged
Add load stages #760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`routing_batch_function`
CodSpeed Performance ReportMerging #760 will not alter performanceComparing Summary
|
plaguss
approved these changes
Jul 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noice!
Co-authored-by: Agus <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a new feature in which the steps are divided in several load stages marked by the position of the
GlobalStep
s in the pipeline.GlobalStep
s receives all the data at once (in one batch), and therefore, they require all its previous steps to have finished before being able of processing the data. Having that said, it's not necessary to load theGlobalStep
until its previous steps have finished its execution, saving some resources in the meantime. Also, it's not necessary to load the successors steps of aGlobalStep
until it has finished it's execution. Therefore, the load stages are marked by the position of theGlobalStep
s in a pipeline:GlobalStep
will be grouped in a stage.GlobalStep
will have it's own stage.GlobalStep
will be grouped in a stage.