Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add load stages #760

Merged
merged 34 commits into from
Jul 3, 2024
Merged

Add load stages #760

merged 34 commits into from
Jul 3, 2024

Conversation

gabrielmbmb
Copy link
Member

Description

This PR adds a new feature in which the steps are divided in several load stages marked by the position of the GlobalSteps in the pipeline. GlobalSteps receives all the data at once (in one batch), and therefore, they require all its previous steps to have finished before being able of processing the data. Having that said, it's not necessary to load the GlobalStep until its previous steps have finished its execution, saving some resources in the meantime. Also, it's not necessary to load the successors steps of a GlobalStep until it has finished it's execution. Therefore, the load stages are marked by the position of the GlobalSteps in a pipeline:

  1. Previous steps of a GlobalStep will be grouped in a stage.
  2. Each GlobalStep will have it's own stage.
  3. Successors of a GlobalStep will be grouped in a stage.

@gabrielmbmb gabrielmbmb added the enhancement New feature or request label Jun 27, 2024
@gabrielmbmb gabrielmbmb added this to the 1.3.0 milestone Jun 27, 2024
@gabrielmbmb gabrielmbmb requested a review from plaguss June 27, 2024 15:13
@gabrielmbmb gabrielmbmb self-assigned this Jun 27, 2024
Copy link

codspeed-hq bot commented Jun 27, 2024

CodSpeed Performance Report

Merging #760 will not alter performance

Comparing steps-load-stages (b5605fb) with develop (91bc0fa)

Summary

✅ 1 untouched benchmarks

@gabrielmbmb gabrielmbmb marked this pull request as ready for review June 28, 2024 11:04
@gabrielmbmb gabrielmbmb linked an issue Jun 28, 2024 that may be closed by this pull request
Copy link
Contributor

@plaguss plaguss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noice!

src/distilabel/pipeline/base.py Outdated Show resolved Hide resolved
src/distilabel/pipeline/base.py Outdated Show resolved Hide resolved
@gabrielmbmb gabrielmbmb merged commit 87b8f85 into develop Jul 3, 2024
7 checks passed
@gabrielmbmb gabrielmbmb deleted the steps-load-stages branch July 3, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Load GlobalSteps only when is needed and load stages
2 participants