Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default name for a pipeline #809

Merged
merged 3 commits into from
Jul 25, 2024
Merged

Conversation

plaguss
Copy link
Contributor

@plaguss plaguss commented Jul 23, 2024

Description

Generate a random name for the pipeline if one is not given by default, to simplify cognitive load:

from distilabel.pipeline import Pipeline

with Pipeline() as pipeline:
    print(pipeline.name)

A name like the pipeline_33prTGVu will appear by default from now on, unless the name is given.

@plaguss plaguss added this to the 1.3.0 milestone Jul 23, 2024
@plaguss plaguss requested review from dvsrepo and gabrielmbmb July 23, 2024 08:17
@plaguss plaguss self-assigned this Jul 23, 2024
@plaguss plaguss linked an issue Jul 23, 2024 that may be closed by this pull request
Copy link

Documentation for this PR has been built. You can view it at: https://distilabel.argilla.io/pr-809/

Copy link

codspeed-hq bot commented Jul 23, 2024

CodSpeed Performance Report

Merging #809 will not alter performance

Comparing pipeline-name-optional (6d9c6d6) with develop (b7f124f)

Summary

✅ 1 untouched benchmarks

@davidberenstein1957
Copy link
Member

davidberenstein1957 commented Jul 25, 2024

@plaguss is this included for Steps and LLMs too? I think we could include it there too and perhaps generalize something to f"{step_name}-{step_number}-{uuid}"?

@plaguss
Copy link
Contributor Author

plaguss commented Jul 25, 2024

Hi @davidberenstein1957, the LLMs don't need it, the steps already have it implemented

@davidberenstein1957
Copy link
Member

davidberenstein1957 commented Jul 25, 2024

@plaguss perhaps we should update and simplify the docs where needed?

@plaguss
Copy link
Contributor Author

plaguss commented Jul 25, 2024

Yes totally, there are some updates in #812 to the quickstart for example that should contain this (it should be here, but they are a bit mixed). Maybe we should review the docs after these 2 PRs are merged and see what to improve? Thanks for the review 🤗

@gabrielmbmb gabrielmbmb merged commit a4d2f2e into develop Jul 25, 2024
7 checks passed
@gabrielmbmb gabrielmbmb deleted the pipeline-name-optional branch July 25, 2024 15:13
@MandyLoc60 MandyLoc60 mentioned this pull request Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Make Pipeline name optional
3 participants