Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request batches to GeneratorStep if only step in pipeline #828

Merged
merged 2 commits into from
Jul 24, 2024

Conversation

gabrielmbmb
Copy link
Member

Description

This PR updates the function _manage_batch_flow to request more batches to the GeneratorSteps if the pipeline only contains one step and it's a GeneratorStep. This is useful for use cases in which a GeneratorTask is used such as MagpieGenerator.

@gabrielmbmb gabrielmbmb added the enhancement New feature or request label Jul 24, 2024
@gabrielmbmb gabrielmbmb added this to the 1.3.0 milestone Jul 24, 2024
@gabrielmbmb gabrielmbmb requested a review from plaguss July 24, 2024 12:55
@gabrielmbmb gabrielmbmb self-assigned this Jul 24, 2024
Copy link

Documentation for this PR has been built. You can view it at: https://distilabel.argilla.io/pr-828/

Copy link

codspeed-hq bot commented Jul 24, 2024

CodSpeed Performance Report

Merging #828 will not alter performance

Comparing request-batches-if-only-generator (92b40c4) with develop (e99ecdf)

Summary

✅ 1 untouched benchmarks

@gabrielmbmb gabrielmbmb merged commit 90909ab into develop Jul 24, 2024
7 checks passed
@gabrielmbmb gabrielmbmb deleted the request-batches-if-only-generator branch July 24, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant