Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create new distilabel.constants module to store constants and avoid circular imports #861

Merged
merged 3 commits into from
Aug 7, 2024

Conversation

plaguss
Copy link
Contributor

@plaguss plaguss commented Aug 7, 2024

Description

The modules:
distilabel.steps.constants and distilabel.pipeline.constants have been moved to distilabel.constants to avoid circular imports.

Closes #860

@plaguss plaguss added the fix label Aug 7, 2024
@plaguss plaguss requested a review from gabrielmbmb August 7, 2024 08:24
@plaguss plaguss self-assigned this Aug 7, 2024
Copy link

github-actions bot commented Aug 7, 2024

Documentation for this PR has been built. You can view it at: https://distilabel.argilla.io/pr-861/

src/distilabel/__init__.py Outdated Show resolved Hide resolved
Co-authored-by: Gabriel Martín Blázquez <[email protected]>
@gabrielmbmb gabrielmbmb merged commit 1b43450 into main Aug 7, 2024
5 of 6 checks passed
@gabrielmbmb gabrielmbmb deleted the distiset-circular-import branch August 7, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Circular import with distilabel.distiset module
2 participants