Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix default structured output #892

Merged
merged 5 commits into from
Aug 13, 2024
Merged

Conversation

plaguss
Copy link
Contributor

@plaguss plaguss commented Aug 13, 2024

Description

This PR updates the tests affected by the addition of use_default_structured_output in the tasks when, let's the value to False by default, and adds an extra check for the dependency at the time of setting the default value

@plaguss plaguss added this to the 1.4.0 milestone Aug 13, 2024
@plaguss plaguss requested a review from gabrielmbmb August 13, 2024 10:07
@plaguss plaguss self-assigned this Aug 13, 2024
Copy link

Documentation for this PR has been built. You can view it at: https://distilabel.argilla.io/pr-892/

Copy link

codspeed-hq bot commented Aug 13, 2024

CodSpeed Performance Report

Merging #892 will not alter performance

Comparing fix-default-structured-output (f00420b) with develop (8916ff2)

Summary

✅ 1 untouched benchmarks

@plaguss plaguss added fix and removed test labels Aug 13, 2024
@gabrielmbmb gabrielmbmb merged commit 75baf64 into develop Aug 13, 2024
6 of 7 checks passed
@gabrielmbmb gabrielmbmb deleted the fix-default-structured-output branch August 13, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants