Add support for templatable exit handlers and V4 examples #613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Flaviu Vadan <[email protected]>
Signed-off-by: Flaviu Vadan <[email protected]>
Signed-off-by: Flaviu Vadan <[email protected]>
flaviuvadan
added
semver:patch
flaviuvadan
changed the title
Signed-off-by: Flaviu Vadan <[email protected]>
Signed-off-by: Flaviu Vadan <[email protected]>
Signed-off-by: Flaviu Vadan <[email protected]>
Signed-off-by: Flaviu Vadan <[email protected]>
Signed-off-by: Flaviu Vadan <[email protected]>
Signed-off-by: Flaviu Vadan <[email protected]>
Signed-off-by: Flaviu Vadan <[email protected]>
Signed-off-by: Flaviu Vadan <[email protected]>
Signed-off-by: Flaviu Vadan <[email protected]>
Signed-off-by: Flaviu Vadan <[email protected]>
Signed-off-by: Flaviu Vadan <[email protected]>
Signed-off-by: Flaviu Vadan <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #613 +/- ##
=======================================
- Coverage 72.4% 64.9% -7.6%
=======================================
Files 42 42
Lines 2916 2968 +52
Branches 572 563 -9
=======================================
- Hits 2113 1928 -185
- Misses 649 914 +265
+ Partials 154 126 -28
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
# Conflicts: # src/hera/workflows/_mixins.py
4 tasks
elliotgunton
reviewed
May 9, 2023
4 tasks
flaviuvadan
added a commit
that referenced
this pull request
May 26, 2023
<!-- Thank you for submitting a PR to Hera! 🚀 --> **Pull Request Checklist** - [x] Fixes #595 - [ ] Tests added - [x] Documentation/examples added - [x] [Good commit messages](https://cbea.ms/git-commit/) and/or PR title <!-- Also remember to sign off commits or the DCO check will fail on your PR! --> **Description of PR** <!-- If not linked to an issue, please describe your changes here --> @elliotgunton and I bounced some thoughts on improving access to parameters/artifact via #595 and #613. This PR adds the implementation @elliotgunton suggested to the template invokator class. Open to having these on a different mixin! <!-- Piece of cake! ✨🍰✨ --> --------- Signed-off-by: Flaviu Vadan <[email protected]> Signed-off-by: Elliot Gunton <[email protected]> Co-authored-by: Sambhav Kothari <[email protected]> Co-authored-by: Elliot Gunton <[email protected]>
|
closing in favor of #650 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Description of PR
Currently, the Hera v4 examples are mostly missing. This PR adds numerous examples from V4 and also fixes a few tiny bugs that were identified: