Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2.6 RC1: missing required field "pathParamPrefix" in io.argoproj.v1alpha1.ApplicationSet.spec.generators.git #11796

Closed
3 tasks done
gaeljw opened this issue Dec 21, 2022 · 3 comments · Fixed by #11943
Closed
3 tasks done

2.6 RC1: missing required field "pathParamPrefix" in io.argoproj.v1alpha1.ApplicationSet.spec.generators.git #11796

gaeljw opened this issue Dec 21, 2022 · 3 comments · Fixed by #11943
Labels
bug Something isn't working cherry-pick/2.6 component:application-sets Bulk application management related
Milestone
v2.6

Comments

@gaeljw
Copy link
Contributor

gaeljw commented Dec 21, 2022

Checklist:

  • I've searched in the docs and FAQ for my answer: https://bit.ly/argocd-faq.
  • I've included steps to reproduce the bug.
  • I've pasted the output of argocd version.

Describe the bug

After upgrading to 2.6 RC1, we are unable to sync AppSet using a git generator without the pathParamPrefix.

This is related to #10522 but I thought the prefix would be non mandatory.

To Reproduce

Just create an AppSet with git generator. I can provide an example but any will work.

Expected behavior

pathParamPrefix should be optional, at least in a transition phase.

Screenshots

N/A

Version

v2.6.0-rc1+81e40d5

Logs

error validating data: ValidationError(ApplicationSet.spec.generators[0].git): missing required field "pathParamPrefix" in io.argoproj.v1alpha1.ApplicationSet.spec.generators.git
@gaeljw gaeljw added the bug Something isn't working label Dec 21, 2022
@crenshaw-dev crenshaw-dev added the component:application-sets Bulk application management related label Dec 21, 2022
@crenshaw-dev
Copy link
Member

Good catch, it should definitely be optional.

@crenshaw-dev crenshaw-dev added this to the v2.6 milestone Dec 21, 2022
@alecgerona
Copy link

This also happens in v2.5.5+fc3eaec

@sdelrio sdelrio mentioned this issue Jan 7, 2023
Closed
@crenshaw-dev crenshaw-dev added the regression Bug is a regression, should be handled with high priority label Jan 10, 2023
@crenshaw-dev
Copy link
Member

@alecgerona the string pathParamPrefix doesn't exist in the release-2.5 branch. I suspect you applied the latest CRD, which includes that field as required.

@crenshaw-dev crenshaw-dev removed the regression Bug is a regression, should be handled with high priority label Jan 10, 2023
@crenshaw-dev crenshaw-dev mentioned this issue Jan 10, 2023
Merged
crenshaw-dev added a commit that referenced this issue Jan 13, 2023
@crenshaw-dev
fix: pathParamPrefix is optional (#11796) (#11943)
2ddb777 
* fix: pathParamPrefix is optional

Signed-off-by: Michael Crenshaw <[email protected]>

* go mod tidy

Signed-off-by: Michael Crenshaw <[email protected]>

* fix import

Signed-off-by: Michael Crenshaw <[email protected]>

* fix codegen

Signed-off-by: Michael Crenshaw <[email protected]>

Signed-off-by: Michael Crenshaw <[email protected]>
crenshaw-dev added a commit that referenced this issue Jan 13, 2023
@crenshaw-dev
fix: pathParamPrefix is optional (#11796) (#11943)
ee4b3ca 
* fix: pathParamPrefix is optional

Signed-off-by: Michael Crenshaw <[email protected]>

* go mod tidy

Signed-off-by: Michael Crenshaw <[email protected]>

* fix import

Signed-off-by: Michael Crenshaw <[email protected]>

* fix codegen

Signed-off-by: Michael Crenshaw <[email protected]>

Signed-off-by: Michael Crenshaw <[email protected]>
emirot pushed a commit to emirot/argo-cd that referenced this issue Jan 27, 2023
@crenshaw-dev @emirot
fix: pathParamPrefix is optional (argoproj#11796) (argoproj#11943)
102fb0d 
* fix: pathParamPrefix is optional

Signed-off-by: Michael Crenshaw <[email protected]>

* go mod tidy

Signed-off-by: Michael Crenshaw <[email protected]>

* fix import

Signed-off-by: Michael Crenshaw <[email protected]>

* fix codegen

Signed-off-by: Michael Crenshaw <[email protected]>

Signed-off-by: Michael Crenshaw <[email protected]>
Signed-off-by: emirot <[email protected]>
schakrad pushed a commit to schakrad/argo-cd that referenced this issue Mar 14, 2023
@crenshaw-dev @schakrad
fix: pathParamPrefix is optional (argoproj#11796) (argoproj#11943)
eb13dda 
* fix: pathParamPrefix is optional

Signed-off-by: Michael Crenshaw <[email protected]>

* go mod tidy

Signed-off-by: Michael Crenshaw <[email protected]>

* fix import

Signed-off-by: Michael Crenshaw <[email protected]>

* fix codegen

Signed-off-by: Michael Crenshaw <[email protected]>

Signed-off-by: Michael Crenshaw <[email protected]>
Signed-off-by: schakrad <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working cherry-pick/2.6 component:application-sets Bulk application management related
Projects
None yet
Milestone
v2.6
Development

Successfully merging a pull request may close this issue.

fix: pathParamPrefix is optional (#11796) crenshaw-dev/argo-cd
3 participants
@crenshaw-dev @alecgerona @gaeljw