Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: how to change default application details view #12140

Merged
merged 1 commit into from
Jan 30, 2023

Conversation

alexef
Copy link
Member

@alexef alexef commented Jan 25, 2023

this is the documentation for the new feature introduced in #12080.

i didn't mention UI view extensions as I couldn't find it yet in the other docs

Signed-off-by: Alex Eftimie [email protected]

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

@alexef alexef requested review from ashutosh16 and rbreeze January 25, 2023 20:33
@codecov
Copy link

codecov bot commented Jan 25, 2023

Codecov Report

Base: 47.41% // Head: 47.41% // No change to project coverage 👍

Coverage data is based on head (bf10a8a) compared to base (b2a6387).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #12140   +/-   ##
=======================================
  Coverage   47.41%   47.41%           
=======================================
  Files         246      246           
  Lines       41815    41815           
=======================================
  Hits        19825    19825           
  Misses      19994    19994           
  Partials     1996     1996           
Impacted Files Coverage Δ
util/settings/settings.go 48.27% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@rbreeze rbreeze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

One thought: do you envision this feature being used exclusively by operators? If you envision a user ever wanting to customize this, maybe this would fit better under User Guide. I'll leave it up to you

@alexef
Copy link
Member Author

alexef commented Jan 30, 2023

I see it as an advanced feature for operators, yes. For instance, for us, users don't even have access to their Applications to modify annotations like this.

@rbreeze rbreeze merged commit 9bd1033 into argoproj:master Jan 30, 2023
schakrad pushed a commit to schakrad/argo-cd that referenced this pull request Mar 14, 2023
Signed-off-by: Alex Eftimie <[email protected]>
Signed-off-by: schakrad <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants