fix: add CLI client IDs to default OIDC allowed audiences (#12170) #12179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yann Soubeyrand <[email protected]>
…2170) Signed-off-by: Michael Crenshaw <[email protected]>
10 tasks
Signed-off-by: Michael Crenshaw <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>
leoluz
reviewed
Jan 27, 2023
Codecov ReportBase: 47.41% // Head: 47.43% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #12179 +/- ##
==========================================
+ Coverage 47.41% 47.43% +0.02%
==========================================
Files 246 246
Lines 41815 41824 +9
==========================================
+ Hits 19825 19838 +13
+ Misses 19994 19990 -4
Partials 1996 1996
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
crenshaw-dev
added
cherry-pick/2.3
|
Cherry-picked onto release-2.6 for 2.6.0-rc6, release-2.5 for 2.5.9, release-2.4 for 2.4.21, and release-2.3 for 2.3.15. |
crenshaw-dev
added a commit
that referenced
this pull request
Jan 27, 2023
…12179) * fix(settings): add CLI client ID in default OAuth2 allowed audiences Signed-off-by: Yann Soubeyrand <[email protected]> * fix: add CLI client IDs to default OIDC allowed audiences (#12170) Signed-off-by: Michael Crenshaw <[email protected]> * docs Signed-off-by: Michael Crenshaw <[email protected]> * test Signed-off-by: Michael Crenshaw <[email protected]> * handle expired token properly Signed-off-by: Michael Crenshaw <[email protected]> --------- Signed-off-by: Yann Soubeyrand <[email protected]> Signed-off-by: Michael Crenshaw <[email protected]> Co-authored-by: Yann Soubeyrand <[email protected]>
crenshaw-dev
added a commit
that referenced
this pull request
Jan 27, 2023
…12179) * fix(settings): add CLI client ID in default OAuth2 allowed audiences Signed-off-by: Yann Soubeyrand <[email protected]> * fix: add CLI client IDs to default OIDC allowed audiences (#12170) Signed-off-by: Michael Crenshaw <[email protected]> * docs Signed-off-by: Michael Crenshaw <[email protected]> * test Signed-off-by: Michael Crenshaw <[email protected]> * handle expired token properly Signed-off-by: Michael Crenshaw <[email protected]> --------- Signed-off-by: Yann Soubeyrand <[email protected]> Signed-off-by: Michael Crenshaw <[email protected]> Co-authored-by: Yann Soubeyrand <[email protected]>
crenshaw-dev
added a commit
that referenced
this pull request
Jan 27, 2023
…12179) * fix(settings): add CLI client ID in default OAuth2 allowed audiences Signed-off-by: Yann Soubeyrand <[email protected]> * fix: add CLI client IDs to default OIDC allowed audiences (#12170) Signed-off-by: Michael Crenshaw <[email protected]> * docs Signed-off-by: Michael Crenshaw <[email protected]> * test Signed-off-by: Michael Crenshaw <[email protected]> * handle expired token properly Signed-off-by: Michael Crenshaw <[email protected]> --------- Signed-off-by: Yann Soubeyrand <[email protected]> Signed-off-by: Michael Crenshaw <[email protected]> Co-authored-by: Yann Soubeyrand <[email protected]>
crenshaw-dev
added a commit
that referenced
this pull request
Jan 27, 2023
…12179) * fix(settings): add CLI client ID in default OAuth2 allowed audiences Signed-off-by: Yann Soubeyrand <[email protected]> * fix: add CLI client IDs to default OIDC allowed audiences (#12170) Signed-off-by: Michael Crenshaw <[email protected]> * docs Signed-off-by: Michael Crenshaw <[email protected]> * test Signed-off-by: Michael Crenshaw <[email protected]> * handle expired token properly Signed-off-by: Michael Crenshaw <[email protected]> --------- Signed-off-by: Yann Soubeyrand <[email protected]> Signed-off-by: Michael Crenshaw <[email protected]> Co-authored-by: Yann Soubeyrand <[email protected]>
emirot
pushed a commit
to emirot/argo-cd
that referenced
this pull request
Jan 27, 2023
…2170) (argoproj#12179) * fix(settings): add CLI client ID in default OAuth2 allowed audiences Signed-off-by: Yann Soubeyrand <[email protected]> * fix: add CLI client IDs to default OIDC allowed audiences (argoproj#12170) Signed-off-by: Michael Crenshaw <[email protected]> * docs Signed-off-by: Michael Crenshaw <[email protected]> * test Signed-off-by: Michael Crenshaw <[email protected]> * handle expired token properly Signed-off-by: Michael Crenshaw <[email protected]> --------- Signed-off-by: Yann Soubeyrand <[email protected]> Signed-off-by: Michael Crenshaw <[email protected]> Co-authored-by: Yann Soubeyrand <[email protected]> Signed-off-by: emirot <[email protected]>
todaywasawesome
pushed a commit
to codefresh-io/argo-cd
that referenced
this pull request
Feb 6, 2023
…2170) (argoproj#12179) * fix(settings): add CLI client ID in default OAuth2 allowed audiences Signed-off-by: Yann Soubeyrand <[email protected]> * fix: add CLI client IDs to default OIDC allowed audiences (argoproj#12170) Signed-off-by: Michael Crenshaw <[email protected]> * docs Signed-off-by: Michael Crenshaw <[email protected]> * test Signed-off-by: Michael Crenshaw <[email protected]> * handle expired token properly Signed-off-by: Michael Crenshaw <[email protected]> --------- Signed-off-by: Yann Soubeyrand <[email protected]> Signed-off-by: Michael Crenshaw <[email protected]> Co-authored-by: Yann Soubeyrand <[email protected]>
pasha-codefresh
added a commit
to codefresh-io/argo-cd
that referenced
this pull request
Feb 7, 2023
* fix: verify audience claim Co-Authored-By: Vladimir Pouzanov <[email protected]> Signed-off-by: CI <[email protected]> * fix unit tests Signed-off-by: Michael Crenshaw <[email protected]> * handle single aud claim marshaled as a string Signed-off-by: Michael Crenshaw <[email protected]> * fix dependencies * fix: add CLI client IDs to default OIDC allowed audiences (argoproj#12170) (argoproj#12179) * fix(settings): add CLI client ID in default OAuth2 allowed audiences Signed-off-by: Yann Soubeyrand <[email protected]> * fix: add CLI client IDs to default OIDC allowed audiences (argoproj#12170) Signed-off-by: Michael Crenshaw <[email protected]> * docs Signed-off-by: Michael Crenshaw <[email protected]> * test Signed-off-by: Michael Crenshaw <[email protected]> * handle expired token properly Signed-off-by: Michael Crenshaw <[email protected]> --------- Signed-off-by: Yann Soubeyrand <[email protected]> Signed-off-by: Michael Crenshaw <[email protected]> Co-authored-by: Yann Soubeyrand <[email protected]> * fix dependencies * update version * update version * update version * fix linter * fix linter --------- Signed-off-by: CI <[email protected]> Signed-off-by: Michael Crenshaw <[email protected]> Signed-off-by: Yann Soubeyrand <[email protected]> Co-authored-by: CI <[email protected]> Co-authored-by: Vladimir Pouzanov <[email protected]> Co-authored-by: pashakostohrys <[email protected]> Co-authored-by: Yann Soubeyrand <[email protected]>
schakrad
pushed a commit
to schakrad/argo-cd
that referenced
this pull request
Mar 14, 2023
…2170) (argoproj#12179) * fix(settings): add CLI client ID in default OAuth2 allowed audiences Signed-off-by: Yann Soubeyrand <[email protected]> * fix: add CLI client IDs to default OIDC allowed audiences (argoproj#12170) Signed-off-by: Michael Crenshaw <[email protected]> * docs Signed-off-by: Michael Crenshaw <[email protected]> * test Signed-off-by: Michael Crenshaw <[email protected]> * handle expired token properly Signed-off-by: Michael Crenshaw <[email protected]> --------- Signed-off-by: Yann Soubeyrand <[email protected]> Signed-off-by: Michael Crenshaw <[email protected]> Co-authored-by: Yann Soubeyrand <[email protected]> Signed-off-by: schakrad <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12170