fix: show full event message in pod event view (#12104) #12267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pplicationListView. Signed-off-by: schakradari <[email protected]>
Signed-off-by: schakradari <[email protected]>
Signed-off-by: schakradari <[email protected]>
Codecov ReportBase: 47.62% // Head: 47.62% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #12267 +/- ##
=======================================
Coverage 47.62% 47.62%
=======================================
Files 246 246
Lines 41797 41797
=======================================
Hits 19907 19907
Misses 19897 19897
Partials 1993 1993
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Signed-off-by: schakrad <[email protected]>
ciiay
reviewed
Feb 3, 2023
ui/src/app/applications/components/application-details/application-resource-list.tsx
Outdated
Show resolved
Hide resolved
|
This is very useful. I believe we have similar issues (text is truncated with elipsis) in other places, such as:
Can you apply the same fix there, or should we make it a separate code change? |
alexef
added
enhancement
@alexef , Could you please raise the above as a new issue? |
crenshaw-dev
added
cherry-pick/2.4
crenshaw-dev
pushed a commit
that referenced
this pull request
Feb 17, 2023
* #11602 fix : Object options menu truncated when selected in ApplicationListView. Signed-off-by: schakradari <[email protected]> * fix for the message to be fully shown under the events section. Signed-off-by: schakradari <[email protected]> * fixing lint Signed-off-by: schakradari <[email protected]> * Update application-resource-list.tsx Signed-off-by: schakrad <[email protected]> * fix for lint error Signed-off-by: schakradari <[email protected]> --------- Signed-off-by: schakradari <[email protected]> Signed-off-by: schakrad <[email protected]>
crenshaw-dev
pushed a commit
that referenced
this pull request
Feb 17, 2023
* #11602 fix : Object options menu truncated when selected in ApplicationListView. Signed-off-by: schakradari <[email protected]> * fix for the message to be fully shown under the events section. Signed-off-by: schakradari <[email protected]> * fixing lint Signed-off-by: schakradari <[email protected]> * Update application-resource-list.tsx Signed-off-by: schakrad <[email protected]> * fix for lint error Signed-off-by: schakradari <[email protected]> --------- Signed-off-by: schakradari <[email protected]> Signed-off-by: schakrad <[email protected]>
crenshaw-dev
pushed a commit
that referenced
this pull request
Feb 17, 2023
* #11602 fix : Object options menu truncated when selected in ApplicationListView. Signed-off-by: schakradari <[email protected]> * fix for the message to be fully shown under the events section. Signed-off-by: schakradari <[email protected]> * fixing lint Signed-off-by: schakradari <[email protected]> * Update application-resource-list.tsx Signed-off-by: schakrad <[email protected]> * fix for lint error Signed-off-by: schakradari <[email protected]> --------- Signed-off-by: schakradari <[email protected]> Signed-off-by: schakrad <[email protected]>
|
Cherry-picked onto release-2.6 for 2.6.3, release-2.5 for 2.5.12, and release-2.4 for 2.4.24. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist:
Note on DCO: