Issue #1665 - Stuck processor on App Controller after deleting application with incomplete operation #1666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexec
approved these changes
May 30, 2019
| @@ -551,6 +551,10 @@ func (ctrl *ApplicationController) setOperationState(app *appv1.Application, sta | |||
| appClient := ctrl.applicationClientset.ArgoprojV1alpha1().Applications(ctrl.namespace) | |||
| _, err = appClient.Patch(app.Name, types.MergePatchType, patchJSON) | |||
| if err != nil { | |||
| // Stop retrying updating deleted application | |||
| if apierr.IsNotFound(err) { | |||
There was a problem hiding this comment.
You are right. Added the test
Codecov Report
@@ Coverage Diff @@
## master #1666 +/- ##
==========================================
- Coverage 32.62% 32.38% -0.25%
==========================================
Files 71 71
Lines 11319 11247 -72
==========================================
- Hits 3693 3642 -51
+ Misses 7084 7076 -8
+ Partials 542 529 -13
Continue to review full report at Codecov.
|
…g application with incomplete operation
alexmt
force-pushed
the
1665-stuck-operation
branch
from
375aa1d to
456fecb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.