fix: Use different clientID for each EventBus reconnection. Fixes #1055 #1061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…proj#1055 Signed-off-by: Derek Wang <[email protected]>
whynowy
changed the title
whynowy
commented
Feb 8, 2021
| @@ -47,7 +47,7 @@ ENTRYPOINT [ "/bin/eventsource" ] | |||
| #################################################################################################### | |||
| # sensor | |||
| #################################################################################################### | |||
| FROM alpine as sensor | |||
| FROM alpine:3.12.3 as sensor | |||
There was a problem hiding this comment.
The latest alpine release (v3.13.x) has DNS resolving issue, pin to 3.12.3.
Signed-off-by: Derek Wang <[email protected]>
Signed-off-by: Derek Wang <[email protected]>
alexec
approved these changes
Feb 9, 2021
| @@ -382,3 +391,10 @@ func (e *EventSourceAdaptor) Start(ctx context.Context) error { | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| func generateClientID(hostname string) string { | |||
| s1 := rand.NewSource(time.Now().UnixNano()) | |||
There was a problem hiding this comment.
rather than using rand, what about using an RFC compliant UUID?
There was a problem hiding this comment.
juliev0
pushed a commit
to juliev0/argo-events
that referenced
this pull request
Mar 29, 2022
…oproj#1055 (argoproj#1061) * fix: Use differet clientID for each EventBus reconnection. Fixes argoproj#1055 Signed-off-by: Derek Wang <[email protected]> * comment Signed-off-by: Derek Wang <[email protected]> * tiny Signed-off-by: Derek Wang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Derek Wang [email protected]
Checklist: