Refactor gateways #148
Merged
Refactor gateways #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VaibhavPage
commented
Jan 5, 2019
* Refactoring gateway * Updated state handling of event sources * updating gateways * refactor resource gateway * updating gateways * updating gateways * updating gateways * updating gateways * updating gateways * refactoring sensor * refactoring controllers * refactoring controllers * Updating hack * Updating documentation * updated examples * Adding recover in gateways * Gateway is now deployed as a pod instead of deployment * refactoring state machine of sensor and gateway * Updating sensor and gateway state machine * Updating sensor and gateway state machine * Updating examples * Add custom GitHub gateway Issue #95
…events into refactor-gateways
magaldima
reviewed
Jan 10, 2019
|
Added back the tests |
magaldima
reviewed
Jan 16, 2019
| assert.Equal(t, 2, second.Hour()) | ||
| assert.Equal(t, 10, second.Minute()) | ||
| assert.Equal(t, 30, second.Second()) | ||
| convey.Convey("Given an exclusion date", t, func() { |
There was a problem hiding this comment.
I've never heard of convey testing framework? any reason we're using it?
There was a problem hiding this comment.
It allows writing behavior driven tests. Plus it has a nice UI where you can see your "test stories", which part of your is covered by tests, coverage increment/decrement since last run, past test runs statistics etc. http://goconvey.co/
There was a problem hiding this comment.
that's pretty neat. are there others using this? how does it compare to Ginko?
There was a problem hiding this comment.
Both are behavior driven testing framework. I tried both Ginko and Convey and both are kind of on the same level in terms of ease of use , but Convey has a nice UI and it is more popular than Ginko
magaldima
approved these changes
Jan 16, 2019
juliev0
pushed a commit
to juliev0/argo-events
that referenced
this pull request
Mar 29, 2022
* Refactoring gateway * Updated state handling of event sources * updating gateways * refactor resource gateway * updating gateways * updating gateways * updating gateways * updating gateways * updating gateways * refactoring sensor * refactoring controllers * refactoring controllers * Updating hack * Updating documentation * updated examples * Adding recover in gateways * Gateway is now deployed as a pod instead of deployment * refactoring state machine of sensor and gateway * Updating sensor and gateway state machine * Updating sensor and gateway state machine * Updating examples * Updating resource gateway * Updating gateway validation * reverting examples * Add custom GitHub gateway (argoproj#150) * Refactoring gateway * Updated state handling of event sources * updating gateways * refactor resource gateway * updating gateways * updating gateways * updating gateways * updating gateways * updating gateways * refactoring sensor * refactoring controllers * refactoring controllers * Updating hack * Updating documentation * updated examples * Adding recover in gateways * Gateway is now deployed as a pod instead of deployment * refactoring state machine of sensor and gateway * Updating sensor and gateway state machine * Updating sensor and gateway state machine * Updating examples * Add custom GitHub gateway Issue argoproj#95 * minor docs fix * minor docs fix * minor docs fix * Adding tests back * Adding tests back * Adding tests back * Adding tests back * Adding tests back
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#147