Support URL trigger sources #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shrinandj
commented
Jul 26, 2018
pkg/apis/sensor/v1alpha1/types.go
Outdated
| Inline string `json:"inline,omitempty" protobuf:"bytes,2,opt,name=inline"` | ||
| S3 *S3Artifact `json:"s3,omitempty" protobuf:"bytes,1,opt,name=s3"` | ||
| Inline string `json:"inline,omitempty" protobuf:"bytes,2,opt,name=inline"` | ||
| URL *URLArtifact `json:"url,omitempty" protobuf:"bytes,4,opt,name=url"` |
There was a problem hiding this comment.
The offset is intentionally set to 4. 3 will be used for file artifacts (#65).
magaldima
reviewed
Jul 26, 2018
|
|
||
| func (reader *URLReader) Read() ([]byte, error) { | ||
| tr := &http.Transport{ | ||
| TLSClientConfig: &tls.Config{InsecureSkipVerify: true}, |
There was a problem hiding this comment.
Do you think we should be able to support providing options/configuration to the http.Client through the UrlArtifact?
There was a problem hiding this comment.
Good idea.. I'll do a separate PR for this.
Sensor yamls can now specify the workflow location as a url path with this change. Refs argoproj#41
shrinandj
force-pushed
the
shri/support-url-artifacts
branch
from
26068f0 to
0d6f3fb
Compare
magaldima
approved these changes
Jul 26, 2018
juliev0
pushed a commit
to juliev0/argo-events
that referenced
this pull request
Mar 29, 2022
Sensor yamls can now specify the workflow location as a url path with this change. Refs argoproj#41
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sensor yamls can now specify the workflow location as a url path with this change.
Refs #41