fix: switch slack lib and stop using deprecated APIs. Fixes #726 #777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whynowy
commented
Jul 28, 2020
| @@ -127,14 +127,14 @@ func activateRoute(router Router, controller *Controller) { | |||
| } | |||
|
|
|||
| // manageRouteChannels consumes data from route's data channel and stops the processing when the event source is stopped/removed | |||
| func manageRouteChannels(router Router, dispatcher func([]byte) error) { | |||
| func manageRouteChannels(router Router, dispatch func([]byte) error) { | |||
|
Thanks @spkane for testing the RC images! |
VaibhavPage
approved these changes
Jul 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
github.com/nlopes/slacktojackfan.us.kg/slack-go/slack;namespacefield from slack trigger spec;labelsrelated bug introduced by feat: Expose metadata for sensors and fix metadata for eventsources #773;argo-events-sain this PR.Fixes #726