Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use sync.WaitGroup to start eventsoures and sensors #819

Merged
merged 1 commit into from
Aug 7, 2020

Conversation

whynowy
Copy link
Member

@whynowy whynowy commented Aug 6, 2020

Use sync.WaitGroup to start the eventsource service and sensor service, this brings the ability to let the goroutines finish cleaning up when a stop signal issues.

Disabled update-mocks.sh in codegen, since the mock files are not used currently.

@whynowy whynowy changed the title fix: Use WaitGroup to start eventsoures and sensors fix: Use sync.WaitGroup to start eventsoures and sensors Aug 6, 2020
@whynowy whynowy requested a review from VaibhavPage August 6, 2020 06:55
@zachaller
Copy link
Contributor

Now I get what expected as well, thanks

{"level":"info","ts":1596719845.3426712,"logger":"argo-events.eventsource","caller":"eventsources/eventing.go:336","msg":"Shutting down...","eventSourceName":"kafka"}
{"level":"info","ts":1596719845.3427703,"logger":"argo-events.eventsource","caller":"eventsources/eventing.go:278","msg":"exiting eventbus connection daemon...","eventSourceName":"kafka"}
{"level":"info","ts":1596719845.342825,"logger":"argo-events.eventsource","caller":"kafka/start.go:151","msg":"terminating: context cancelled","eventSourceName":"kafka","eventSourceType":"kafka","eventName":"example"}
{"level":"info","ts":1596719845.3853364,"logger":"argo-events.eventsource","caller":"kafka/start.go:140","msg":"Error from context: context canceled","eventSourceName":"kafka","eventSourceType":"kafka","eventName":"example"}

@whynowy whynowy merged commit 6471850 into argoproj:master Aug 7, 2020
@whynowy whynowy deleted the fix branch August 7, 2020 15:05
juliev0 pushed a commit to juliev0/argo-events that referenced this pull request Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants