Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: upgrade rpc module #10030 #10054

Closed
wants to merge 1 commit into from
Closed

fix: upgrade rpc module #10030 #10054

wants to merge 1 commit into from

Conversation

shogohida
Copy link

@shogohida shogohida commented Nov 17, 2022 •
edited
Loading

Signed-off-by: Shogo Hida [email protected]

Fixes #10030

Please do not open a pull request until you have checked ALL of these:

  • Create the PR as draft .
  • Run make pre-commit -B to fix codegen and lint problems.
  • Sign-off your commits (otherwise the DCO check will fail).
  • Use a conventional commit message (otherwise the commit message check will fail).
  • "Fixes #" is in both the PR title (for release notes) and this description (to automatically link and close the issue).
  • Add unit or e2e tests. Say how you tested your changes. If you changed the UI, attach screenshots.
  • Github checks are green.
  • Once required tests have passed, mark your PR "Ready for review".

If changes were requested, and you've made them, dismiss the review to get it reviewed again.

@shogohida
fix: upgrade rpc module
d29c3e0 
Signed-off-by: Shogo Hida <[email protected]>
terrytangyuan
terrytangyuan requested changes Nov 18, 2022
View reviewed changes
Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix lint

@shogohida shogohida force-pushed the upgrade-rpc branch 2 times, most recently from 962317f to d29c3e0 Compare November 18, 2022 18:44
@stale
Copy link

stale bot commented Dec 31, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If this is a mentoring request, please provide an update here. Thank you for your contributions.

@stale stale bot added the problem/stale This has not had a response in some time label Dec 31, 2022
@stale
Copy link

stale bot commented Jan 8, 2023

This issue has been closed due to inactivity. Feel free to re-open if you still encounter this issue.

@stale stale bot closed this Jan 8, 2023
@agilgur5
Copy link

agilgur5 commented Aug 8, 2023

Replaced by #11543

@agilgur5 agilgur5 added type/dependencies PRs and issues specific to updating dependencies go Pull requests that update Go dependencies and removed problem/stale This has not had a response in some time labels Aug 20, 2023
@agilgur5 agilgur5 added the solution/superseded This PR or issue has been superseded by another one (slightly different from a duplicate) label Feb 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terrytangyuan terrytangyuan terrytangyuan requested changes

Assignees
No one assigned
Labels
go Pull requests that update Go dependencies solution/superseded This PR or issue has been superseded by another one (slightly different from a duplicate) type/dependencies PRs and issues specific to updating dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade rpc module to v2.0.3
3 participants
@shogohida @agilgur5 @terrytangyuan