Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Ignore SIGURG in argoexec emissary. Fixes #10129 #10141

Merged
merged 1 commit into from
Dec 1, 2022

Conversation

superbrothers
Copy link
Contributor

@superbrothers superbrothers commented Nov 30, 2022

SIGURG is frequently sent from argoexec emissary to user's commands. This is noise because some applications, such as OpenMPI, log the signals they receive. SIGURG is used for goroutine preemption from go1.14.

https://github.com/golang/proposal/blob/master/design/24543-non-cooperative-preemption.md#other-considerations

Therefore we ignore and don't forward SIGURG to the user command.

Fixes #10129

Please do not open a pull request until you have checked ALL of these:

  • Create the PR as draft .
  • Run make pre-commit -B to fix codegen and lint problems.
  • Sign-off your commits (otherwise the DCO check will fail).
  • Use a conventional commit message (otherwise the commit message check will fail).
  • "Fixes #" is in both the PR title (for release notes) and this description (to automatically link and close the issue).
  • Add unit or e2e tests. Say how you tested your changes. If you changed the UI, attach screenshots.
  • Github checks are green.
  • Once required tests have passed, mark your PR "Ready for review".

If changes were requested, and you've made them, dismiss the review to get it reviewed again.

SIGURG is frequently sent from argoexec emissary to user's commands.
This is noise because some applications, such as OpenMPI, log the
signals they receive. SIGURG is used for goroutine preemption from
go1.14.

https://github.com/golang/proposal/blob/master/design/24543-non-cooperative-preemption.md#other-considerations

Therefore we ignore and don't forward SIGURG to the user command.

Signed-off-by: Kazuki Suda <[email protected]>
@superbrothers superbrothers marked this pull request as ready for review November 30, 2022 08:55
@alexec alexec merged commit 6166464 into argoproj:master Dec 1, 2022
@superbrothers superbrothers deleted the ignore-SIGURG branch December 1, 2022 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ignore SIGURG from argoexec emissary
3 participants