feat: Ignore SIGURG in argoexec emissary. Fixes #10129 #10141
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SIGURG is frequently sent from argoexec emissary to user's commands. This is noise because some applications, such as OpenMPI, log the signals they receive. SIGURG is used for goroutine preemption from go1.14.
https://github.com/golang/proposal/blob/master/design/24543-non-cooperative-preemption.md#other-considerations
Therefore we ignore and don't forward SIGURG to the user command.
Fixes #10129
Please do not open a pull request until you have checked ALL of these:
make pre-commit -B
to fix codegen and lint problems.If changes were requested, and you've made them, dismiss the review to get it reviewed again.