fix: check hooked nodes in executeWfLifeCycleHook and executeTmplLifeCycleHook (#11113, #11117)

[toyamagu-2021]

Signed-off-by: [email protected] [email protected]

Fixes #11113
Fixes #11117

Motivation

• Check hooked node statuses even workflows completed.

Modifications

• Check hooked node statuses in executeWfLifeCycleHook and executeTmplLifeCycleHook

Verification

• Unit tests and e2e-tests
• fixes issue Workflow becomes completed before some template triggered by LifecycleHook Running is completed #11113
  • 
• fixes issue Hook from a template with mutex does not release lock after completion #11117
  • Note that we should sleep for some seconds in jobs to wait for trigger Running hooks.
  • This problem might be resolved by parallel executing of Running hooks, but that is beyond the scope of this PR.
  • 

manifest

```yaml apiVersion: argoproj.io/v1alpha1 kind: Workflow metadata: generateName: example-steps-simple-mutex spec: entrypoint: main

templates:
- name: main
steps:
- - name: job-1
template: sleep
arguments:
parameters:
- name: sleep_duration
value: 30
hooks:
running:
expression: steps['job-1'].status == "Running"
template: hook
arguments:
parameters:
- name: sleep_duration
value: 5
- name: context
value: "job-1"
success:
expression: steps['job-1'].status == "Succeeded"
template: hook
arguments:
parameters:
- name: sleep_duration
value: 5
- name: context
value: "job-1"
- name: job-2
template: sleep
arguments:
parameters:
- name: sleep_duration
value: 30
hooks:
running:
expression: steps['job-2'].status == "Running"
template: hook
arguments:
parameters:
- name: sleep_duration
value: 5
- name: context
value: "job-2"
success:
expression: steps['job-2'].status == "Succeeded"
template: hook
arguments:
parameters:
- name: sleep_duration
value: 5
- name: context
value: "job-2"
- name: job-3
template: sleep
arguments:
parameters:
- name: sleep_duration
value: 30
hooks:
running:
expression: steps['job-3'].status == "Running"
template: hook
arguments:
parameters:
- name: sleep_duration
value: 45
- name: context
value: "job-3"
success:
expression: steps['job-3'].status == "Succeeded"
template: hook
arguments:
parameters:
- name: sleep_duration
value: 5
- name: context
value: "job-3"

- name: hook
  synchronization:
    mutex:
      name: "{{ inputs.parameters.context }}"
  inputs:
    parameters:
      - name: sleep_duration
      - name: context
  script:
    image: alpine:latest
    command: [/bin/sh]
    source: |
      echo "Fake API call - sleeping for {{ inputs.parameters.sleep_duration }}, context is {{ inputs.parameters.context }}"
      sleep {{ inputs.parameters.sleep_duration }}

- name: sleep
  inputs:
    parameters:
      - name: sleep_duration
  script:
    image: alpine:latest
    command: [/bin/sh]
    source: |
      echo "Sleeping for {{ inputs.parameters.sleep_duration }}"
      sleep {{ inputs.parameters.sleep_duration }}

</details>

[toyamagu-2021]

@sarabala1979
Hi, could you take a look at this?