fix: Upgrade windows container to ltsc2022 #11246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Can you try trigger a release build but only builds the image? https://github.com/argoproj/argo-workflows/blob/master/.github/workflows/release.yaml
|
I don't have permissions to do that. |
|
You can comment out most of it and only runs a docker build on Windows. You can run modify it to run it in your fork too |
|
This PR remains in draft for now, but I have something working @terrytangyuan if you wish to test: |
Signed-off-by: Tim Collins <[email protected]>
…er version Signed-off-by: Tim Collins <[email protected]>
|
If it's working, we can merge it. Let me know when ready. |
|
Moving back to draft. The pull test failed |
terrytangyuan
changed the title
|
Err. It's not. But... ok? |
JPZ13
pushed a commit
to pipekit/argo-workflows
that referenced
this pull request
Jul 4, 2023
Signed-off-by: Tim Collins <[email protected]>
jeremyhager
pushed a commit
to jeremyhager/argo-workflows
that referenced
this pull request
Jul 7, 2023
Signed-off-by: Tim Collins <[email protected]> Signed-off-by: Jeremy Hager <[email protected]>
61 tasks
terrytangyuan
pushed a commit
that referenced
this pull request
Jul 19, 2023
Signed-off-by: Tim Collins <[email protected]>
dpadhiar
pushed a commit
to dpadhiar/argo-workflows
that referenced
this pull request
May 9, 2024
Signed-off-by: Tim Collins <[email protected]> Signed-off-by: Dillen Padhiar <[email protected]>
agilgur5
added
area/build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10738
and the fact that Windows builds were not releasing.
Older builds were on the 1809 container, which isn't supported any more. Chocolatey recently dropped support and this is what killed the build.
The container we are replacing went out of Microsoft support in November 2020, so this shouldn't be a huge surprise for Windows users: https://learn.microsoft.com/en-us/lifecycle/announcements/windows-10-1809-end-of-servicing
Motivation
Updates to a supported version of Windows and allows the release mechanism to work again.
Modifications
I'm not super familiar with how windows containers work (if they do at all :p) but I think this now means that workflows will only run on server 2022 - it looks like containers are pinned to their host in the least containery-way possible. So this probably requires a minor release of Workflows, not a patch.
Verification
Built on the Pipekit fork and released as mentioned below in the comments.