fix: log level for client-side throttling #11393
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Expresses when throttling occurs on the client side by setting the log message level to Warn. fixes: argoproj#11387 Signed-off-by: Jack-R-lantern <[email protected]>
| @@ -17,7 +17,7 @@ func (m k8sLogRoundTripper) RoundTrip(r *http.Request) (*http.Response, error) { | |||
| x, err := m.roundTripper.RoundTrip(r) | |||
| if x != nil { | |||
| verb, kind := k8s.ParseRequest(r) | |||
| log.Debugf("%s %s %d", verb, kind, x.StatusCode) | |||
| log.Warnf("%s %s %d", verb, kind, x.StatusCode) | |||
There was a problem hiding this comment.
it should be kept at debug, this log is very expensive!
Jack-R-lantern
force-pushed
the
ISSUE-11387/Better-exposure-for-client-side-throttling
branch
from
b05339e to
824c736
Compare
tooptoop4
suggested changes
Jul 19, 2023
| @@ -17,7 +17,7 @@ func (m k8sLogRoundTripper) RoundTrip(r *http.Request) (*http.Response, error) { | |||
| x, err := m.roundTripper.RoundTrip(r) | |||
| if x != nil { | |||
| verb, kind := k8s.ParseRequest(r) | |||
| log.Debugf("%s %s %d", verb, kind, x.StatusCode) | |||
| log.Warnf("%s %s %d", verb, kind, x.StatusCode) | |||
There was a problem hiding this comment.
it should be kept at debug, this log is very expensive!
|
Sorry about that. I'll think about it a bit more and submit a PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expresses when throttling occurs on the
client side by setting the log message level to Warn.
Fixes #11387
Motivation
Modifications
Verification