fix: replace echo -n with echo ...\c in test
#11576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Son Bui <[email protected]>
agilgur5
approved these changes
Aug 15, 2023
| @@ -49,7 +49,7 @@ func TestEmissary(t *testing.T) { | |||
| }) | |||
| t.Run("Sub-process", func(t *testing.T) { | |||
| _ = os.Remove(varRunArgo + "/ctr/main/stdout") | |||
| err := run("(sleep 60; echo 'should not wait for sub-process')& echo -n hello") | |||
| err := run(`(sleep 60; echo 'should not wait for sub-process')& echo "hello\c"`) | |||
There was a problem hiding this comment.
For other readers, note that \c is equivalent to the -n flag. They both mean to not output a trailing newline
terrytangyuan
approved these changes
Aug 15, 2023
5 tasks
terrytangyuan
pushed a commit
that referenced
this pull request
Oct 19, 2023
agilgur5
changed the title
agilgur5
changed the title
echo -n with echo ...\c in test
dpadhiar
pushed a commit
to dpadhiar/argo-workflows
that referenced
this pull request
May 9, 2024
Signed-off-by: Dillen Padhiar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11368
Motivation
Run test fail
Modifications
Replace echo -n with echo ..\c"
Verification
make test