Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed hanging http template manual retry with previous outputs. Fixes #11889 #12122

Closed
wants to merge 9 commits into from
Closed

fix: Fixed hanging http template manual retry with previous outputs. Fixes #11889 #12122

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
8327b48
fix: Fixed hanging http template manual retry with previous outputs. …
wesleyscholl Nov 1, 2023
8f9ab3d
fix: Fixed hanging http template manual retry. Fixes #11889
wesleyscholl Nov 1, 2023
3b9d7d0
fix: Hanging http template manual retry. Fixes #11889
wesleyscholl Nov 1, 2023
8a7006e
fix: Hanging http template manual retry reconcile. Fixes #11889
wesleyscholl Nov 1, 2023
9473c27
fix: Hanging http template on manual retry reconcile tasksets. Fixes …
wesleyscholl Nov 1, 2023
52176ec
fix: Http template retry hang, verified gpg signature. Fixes #11889
wesleyscholl Nov 2, 2023
9b8c229
fix: Hanging manual retry, updated logging. Fixes #11889
wesleyscholl Nov 6, 2023
4e21647
Merge branch 'master' into master
wesleyscholl Nov 6, 2023
a620f3b
fix: Hanging manual retry, e2e tests pass locally. Fixes #11889
wesleyscholl Nov 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions workflow/controller/taskset.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,9 +136,8 @@ func (woc *wfOperationCtx) reconcileTaskSet(ctx context.Context) error {
for nodeID, taskResult := range workflowTaskSet.Status.Nodes {
node, err := woc.wf.Status.Nodes.Get(nodeID)
if err != nil {
woc.log.Warnf("[SPECIAL][DEBUG] returning but assumed validity before")
woc.log.Errorf("[DEBUG] Was unable to obtain node for %s", nodeID)
return err
woc.log.Info("Continuing to retry")
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should definitely be more specific here -- if you read this message in the Controller's logs, it would be pretty ambiguous.

Suggested change
woc.log.Info("Continuing to retry")
woc.log.Debugf("Unable to obtain node for %s during TaskSet Reconciliation. Expected during a retry, continuing", nodeId)

I also think debug level makes more sense here, since this is now an expected error

continue
}

node.Outputs = taskResult.Outputs.DeepCopy()
Expand Down