Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: dynamic namespace parallelism. Fixes #14194 #14188

Merged
merged 47 commits into from
Feb 24, 2025

Conversation

isubasinghe
Copy link
Member

@isubasinghe isubasinghe commented Feb 13, 2025

Fixes #14194

Motivation

This change allows for more granular control of how namespace parallelism works.
This enables you to set parallelism at an individual namespace level instead of the more blanket namespace parallelism flag.

Modifications

This adds a namespace watcher that listens for changes in the namespace objects, by listening to a label. Whenever the labels workflows.argoproj.io/namespace-parallelism-limit is present and with a valid integer value (represented as string), we update the throttler with the new namespace limits.

Verification

An e2e test was added to verify that the code allows for dynamic namespace parallelism.
Additionally manual testing was performed to ensure non-happy paths work.

Documentation

Some documentation was added under parallelism to indicate the presence of this new feature. This could perhaps be more verbose with examples.

Signed-off-by: isubasinghe <[email protected]>
Signed-off-by: isubasinghe <[email protected]>
Signed-off-by: isubasinghe <[email protected]>
Signed-off-by: isubasinghe <[email protected]>
Signed-off-by: isubasinghe <[email protected]>
Signed-off-by: isubasinghe <[email protected]>
Signed-off-by: isubasinghe <[email protected]>
Signed-off-by: isubasinghe <[email protected]>
Signed-off-by: isubasinghe <[email protected]>
Signed-off-by: isubasinghe <[email protected]>
@isubasinghe isubasinghe force-pushed the feat-dynamic-namespace-parallelism branch from fae8582 to 8501244 Compare February 13, 2025 10:48
@Joibel Joibel changed the title feat dynamic namespace parallelism feat: dynamic namespace parallelism Feb 13, 2025
Signed-off-by: isubasinghe <[email protected]>
Signed-off-by: isubasinghe <[email protected]>
Signed-off-by: isubasinghe <[email protected]>
@isubasinghe isubasinghe changed the title feat: dynamic namespace parallelism feat: dynamic namespace parallelism. Fixes #14194 Feb 13, 2025
@isubasinghe isubasinghe marked this pull request as ready for review February 14, 2025 05:10
Signed-off-by: isubasinghe <[email protected]>
Signed-off-by: isubasinghe <[email protected]>
Signed-off-by: isubasinghe <[email protected]>
@isubasinghe isubasinghe requested a review from Joibel February 17, 2025 04:30
Signed-off-by: isubasinghe <[email protected]>
Signed-off-by: isubasinghe <[email protected]>
Signed-off-by: isubasinghe <[email protected]>
Signed-off-by: isubasinghe <[email protected]>
@isubasinghe isubasinghe requested a review from Joibel February 18, 2025 09:42
Signed-off-by: isubasinghe <[email protected]>
Signed-off-by: isubasinghe <[email protected]>
Signed-off-by: isubasinghe <[email protected]>
Signed-off-by: isubasinghe <[email protected]>
Signed-off-by: isubasinghe <[email protected]>
@isubasinghe isubasinghe merged commit dbfedbd into argoproj:main Feb 24, 2025
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow for per namespace modification of parallelism limits.
2 participants