Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module): update import to to /v2 #2347

Closed
wants to merge 1 commit into from

Conversation

tcolgate
Copy link
Contributor

@tcolgate tcolgate commented Mar 3, 2020

This fixes importing argo as a go module. I'm guessing there is a strong
chance that you wont want to fix this, but I thought I'd raise the PR
anyway. The e2e tests fail at present, I'm not sure why.

@tcolgate
Copy link
Contributor Author

tcolgate commented Mar 3, 2020

amusingly enough, I had a port forward open to my ci Instance and accidentally launched all the e2e test jobs on there 💣

@alexec
Copy link
Contributor

alexec commented Mar 6, 2020

@tcolgate let me see if I understand - we cannot import as go module without this change?

@alexec alexec self-assigned this Mar 6, 2020
@tcolgate
Copy link
Contributor Author

tcolgate commented Mar 6, 2020

Not quite, you can't be imported with a regular version import, people have to import a specific commit. That works fine, but they literally need the commit id, can't use the tag.
I am really not sure to want extent this change is a good idea. If you want people to trivially import your code as a package, then maybe it is worth it.
Absolutely don't merge this as is though, I've no idea what it'll break and don't think it even vaguely works.

@alexec
Copy link
Contributor

alexec commented Mar 6, 2020

I think we would want this. How to get it to work?

@alexec alexec linked an issue Apr 7, 2020 that may be closed by this pull request
@alexec alexec added the stale label May 13, 2020
@alexec alexec removed their assignment May 22, 2020
@alexec alexec closed this May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

import latest v2.7.0 argo version in go project
2 participants