fix: Allow setting workflow input parameters in UI. Fixes #4234

[kennytrytek]

Signed-off-by: Kenny Trytek [email protected]

Checklist:

• My organization is added to USERS.md.
  I am committing on my own time.

Local testing showing this fix in action:

Using this WorkflowTemplate

apiVersion: argoproj.io/v1alpha1
kind: WorkflowTemplate
metadata:
  name: whalesay-test
spec:
  entrypoint: whalesay-template
  arguments:
    parameters:
      - name: message
        value: hello
  templates:
    - name: whalesay-template
      inputs:
        parameters:
          - name: message-param-1
      container:
        image: argoproj/argosay:v2
        args: ["echo", "{{inputs.parameters.message-param-1}}"]
        imagePullPolicy: IfNotPresent
    - name: whalesay-template-two
      inputs:
        parameters:
          - name: message-two
      container:
        image: argoproj/argosay:v2
        args: ["echo", "{{inputs.parameters.message-two}}"]
        imagePullPolicy: IfNotPresent

[alexec]

this seems not quite there yet to me, it should not matter which entrypoint you have, the parameters should always be spec.arguments.parameters

[kennytrytek]

@alexec
this seems not quite there yet to me, it should not matter which entrypoint you have, the parameters should always be spec.arguments.parameters

Looking at the example template in the PR description:
Workflow input parameter: message
whalesay-template parameter: message-param-1
whalesay-template-two parameter: message-two

The existing UI is unable to submit the workflow at all because the parameters for whalesay-template and whalesay-template-two do not have default values. How would those values get populated in the workflow submission if they cannot be set in the UI?

[alexec]

Can we break this into 2 PRs?

• One to allow you to choose entrypoint.
• Another where we can discus the arguments.

[kennytrytek]

@alexec, the current UI already allows you to choose an entrypoint, so I don't think there's anything to do for your first bullet point suggestion. This PR should fit the bill for the second bullet point though.

[alexec]

I still can't get my head around this. Can I please ask you to attach an example of a workflow template that this would impact?

[kennytrytek]

@alexec, please see the pull request description for an example workflow template and a GIF showing the UI behavior. The original issue has a GIF showing the current UI behavior for that template.

[alexec]

I think we still need these - otherwise how do you submit the workflow template specifying the spec arguments?

[alexec]

I think we still need these - otherwise how do you submit the workflow template specifying the spec arguments?

[alexec]

@kennytrytek I think we want this PR, but I don't want to lose the ability to set the spec.arguments. Could I please ask you to support both?

[kennytrytek]

Yes, sorry I've been slow on this; I was prioritizing the WorkflowNodeRunning PR ahead of this one. I understand what you're saying; we need to be able to handle the case where there are workflow input parameters, and not just entrypoint parameters.

My current thought is to add an empty option like <none> in the entrypoint selector, using the workflow input parameters for that case.

[alexec]

that sounds good to me

[alexec]

in the future - I'd like to add the ability to resubmit a workflow with different parameters

[codecov]

Codecov Report

Merging #5319 (e1e45ab) into master (f3fe565) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #5319      +/-   ##
==========================================
+ Coverage   47.74%   47.75%   +0.01%     
==========================================
  Files         249      249              
  Lines       15738    15738              
==========================================
+ Hits         7514     7516       +2     
+ Misses       7284     7282       -2     
  Partials      940      940              

Impacted Files	Coverage Δ
workflow/metrics/server.go	16.66% <0.00%> (+4.16%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3fe565...e1e45ab. Read the comment docs.

[kennytrytek]

Sorry for the slow updates on this one. I tested it with some templates from the examples folder, and it appears to do what I would expect; either entrypoint or workflow parameters can be used.