Issue #45: get aws partition based on region #74
Merged
+100
−69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fyi, just found another way to get the partition from ec2 metadata: Might be more reliable over time than hard-coding those properties. |
|
@lorengordon this is awesome! But we have a problem as when user install / upgrade / uninstall cluster from local computer, they don't have access to cloud metadata service so we cannot get it dynamically from their metadata server |
|
Ahh, yes, if the arn is generated from the user environment rather than the cluster environment, that won't work so well. :( |
shrinandj
approved these changes
Aug 29, 2017
icecoffee531
pushed a commit
to icecoffee531/argo-workflows
that referenced
this pull request
Jan 5, 2022
Had to use them as [[overrides]] and not directly as [[constraints]] because argo still uses version v1.9. Testing done: 1. Builds worked just fine. 2. Unit tests worked just fine. 3. Ran the controller and a couple of sensors. They worked too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #45
When creating IAM role / bucket policy, we need to dynamically generate policy string based on aws partition.
Tested install and upgrade and they worked