fix: link to "get artifacts from logs" was assuming Node ID was equal to Pod Name #9464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Julie Vogelman <[email protected]>
Signed-off-by: Julie Vogelman <[email protected]>
Signed-off-by: Julie Vogelman <[email protected]>
juliev0
commented
Aug 30, 2022
ui/src/app/workflows/components/workflow-logs-viewer/workflow-logs-viewer.tsx
Show resolved
Hide resolved
Signed-off-by: Julie Vogelman <[email protected]>
Signed-off-by: Julie Vogelman <[email protected]>
sarabala1979
approved these changes
Aug 30, 2022
3 tasks
juchaosong
pushed a commit
to juchaosong/argo-workflows
that referenced
this pull request
Nov 3, 2022
… to Pod Name (argoproj#9464) * fix: with POD_NAMES v2 we can't pass podName as nodeId Signed-off-by: Julie Vogelman <[email protected]> * fix: with POD_NAMES v2 we can't pass podName as nodeId Signed-off-by: Julie Vogelman <[email protected]> * fix: with POD_NAMES v2 we can't pass podName as nodeId Signed-off-by: Julie Vogelman <[email protected]> * fix: with POD_NAMES v2 we can't pass podName as nodeId Signed-off-by: Julie Vogelman <[email protected]> * fix: empty commit Signed-off-by: Julie Vogelman <[email protected]> Signed-off-by: Julie Vogelman <[email protected]> Signed-off-by: juchao <[email protected]>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hoping this Fixes #9434 but we'll see
At least it does fix the issue seen when running examples/dag-coinflip.yaml
Root cause was that this UI code was never updated to reflect the change to POD_NAMES v2, so it was still assuming that the Pod Name and Node ID would be equal.