Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: exit code always be '0' in windows container. Fixes #9797 #9807

Merged
merged 1 commit into from
Oct 18, 2022
Merged

fix: exit code always be '0' in windows container. Fixes #9797 #9807

merged 1 commit into from
Oct 18, 2022

Conversation

wsj0000
Copy link
Contributor

@wsj0000 wsj0000 commented Oct 13, 2022 •
edited
Loading

Fixes #9797

@wsj0000 wsj0000 mentioned this pull request Oct 13, 2022
Closed
tczhao
tczhao requested changes Oct 13, 2022
View reviewed changes
Copy link
Member

@tczhao tczhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please follow the PR template

  • PR title
    Because we squash merge, the title of the PR will become the commit message.
    Perhaps changing the title to
    fix: exit code always be '0' in windows container. Fixes #9797
    to align with the PR template guide

  • PR description
    In the PR description please use
    Fixes #9797 instead of associated with #9797
    The "Fixes" is a special keyword in github, that will link the PR to issue
    image

@wsj0000 wsj0000 changed the title fix exit code always be '0' in windows container fix: exit code always be '0' in windows container. Fixes #9797 Oct 13, 2022
@wsj0000 wsj0000 requested a review from tczhao October 17, 2022 09:32
@alexec alexec merged commit a752a58 into argoproj:master Oct 18, 2022
juchaosong pushed a commit to juchaosong/argo-workflows that referenced this pull request Nov 3, 2022
@wsj0000 @juchaosong
fix: exit code always be '0' in windows container. Fixes argoproj#9797 (
4141ebc 
argoproj#9807)

Signed-off-by: wsj_0000 <[email protected]>
Signed-off-by: juchao <[email protected]>
@sarabala1979 sarabala1979 mentioned this pull request Nov 8, 2022
Closed
@agilgur5 agilgur5 added area/executor area/windows Windows Container support labels Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexec alexec alexec approved these changes

@tczhao tczhao Awaiting requested review from tczhao

Assignees
No one assigned
Labels
area/executor area/windows Windows Container support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bug] The command exit code always be '0' in windows container
4 participants
@wsj0000 @alexec @tczhao @agilgur5