Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separated jest-dev-server into its own package #67

Merged
merged 2 commits into from
Jun 16, 2018
Merged

Separated jest-dev-server into its own package #67

merged 2 commits into from
Jun 16, 2018

Conversation

JoshuaKGoldberg
Copy link

Fixes #66.

I'm not sure I hooked up everything correctly (never used lerna before; rarely use babel). Would appreciate a stringent review 😄!

@gregberge
Copy link
Member

Good job! I just gave a quick look, it looks OK. I will take a deeper look and merge it this week end. Thanks 🙏

@JoshuaKGoldberg
Copy link
Author

Ping @neoziro - anything I can do to help?

@JoshuaKGoldberg
Copy link
Author

Just a heads up, I ended up needing #71 and added it to jest-dev-server. When this goes in, please don't publish a new version with these changes immediately before we get that feature added in first!

Will edit this post if I end up adding more things to jest-dev-server upstream.

@gregberge
Copy link
Member

@JoshuaKGoldberg OK, I am on it, I think it will done by the end of month.

Joshua Goldberg and others added 2 commits June 16, 2018 14:10
- jest-dev-server can now be used as standalone
- Used port is now automatically detected and a prompt is shown to offer you the opportunity to kill the guilty process

Closes #66
Closes #68
@gregberge gregberge merged commit eb8a35f into argos-ci:master Jun 16, 2018
@JoshuaKGoldberg JoshuaKGoldberg deleted the jest-dev-server branch June 16, 2018 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants