Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update license #132

Merged
merged 3 commits into from
Aug 2, 2024
Merged

update license #132

merged 3 commits into from
Aug 2, 2024

Conversation

johnchandlerburnham
Copy link
Member

No description provided.

huitseeker
huitseeker previously approved these changes Aug 2, 2024
@huitseeker huitseeker dismissed their stale review August 2, 2024 16:51

Misclick

Copy link
Contributor

@huitseeker huitseeker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a condition of the Apache license to not remove the copyright notice of the copyright holder.

We can appose our own, or we can use a Third-party notice that reflects the license of the reused software, see e.g. :
https://github.com/argumentcomputer/arecibo/blob/dev/ThirdPartyNotices.txt

@johnchandlerburnham
Copy link
Member Author

It's a condition of the Apache license to not remove the copyright notice of the copyright holder.

We can appose our own, or we can use a Third-party notice that reflects the license of the reused software, see e.g. : https://github.com/argumentcomputer/arecibo/blob/dev/ThirdPartyNotices.txt

does https://github.com/argumentcomputer/sphinx/blob/dev/ThirdPartyNotices.txt not satisfy this? What other 3rd party notice is needed?

Copy link
Contributor

@huitseeker huitseeker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine, I forgot we had done the 3d-party thing

@johnchandlerburnham johnchandlerburnham merged commit 9960839 into dev Aug 2, 2024
4 of 7 checks passed
@samuelburnham samuelburnham deleted the jcb/license branch August 2, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants