feat: committee program + bench #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tchataigner
force-pushed
the
feature/committee-program
branch
from
0e16744 to
8213575
Compare
fix: as str fix: fix ProvingMode/str conversion feat: benchmark fix: fixed zkvm logs validate update refactor: zkvm logs validate update refactor: zkvm logs process update refactor: remove dbg logs refactor: clearer logs refactor: remove log fix: length of hash for output fix: compiled proper keccak usage fix: proper keccak usage refactor: keccak instead of merkle root refactor: compile program refactor: log cycles fix: assert in execute New sync committee should be the one we had in store fix: fix order of outputs feat: wip #65
tchataigner
force-pushed
the
feature/committee-program
branch
from
8213575 to
32c439d
Compare
huitseeker
approved these changes
Jul 15, 2024
tchataigner
added a commit
that referenced
this pull request
Jul 30, 2024
fix: as str fix: fix ProvingMode/str conversion feat: benchmark fix: fixed zkvm logs validate update refactor: zkvm logs validate update refactor: zkvm logs process update refactor: remove dbg logs refactor: clearer logs refactor: remove log fix: length of hash for output fix: compiled proper keccak usage fix: proper keccak usage refactor: keccak instead of merkle root refactor: compile program refactor: log cycles fix: assert in execute New sync committee should be the one we had in store fix: fix order of outputs feat: wip #65
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the sync committee change program, its tests and benchmark in the same fashion as the ones in the Aptos Light Client.
Test
The documentation for testing this is available in the MdBook.
Performance
On a 128CPU bare metal machine the current performance is:
{ // Time in milliseconds, 13~ minutes "proving_time": 791696, "verification_time": 1 }which means that the proving falls in the performances we want for now.
Changelog
committee_change programthat:current_sync_committeereceived in the storeProvertrait that contains a standard interface for proof execution, proving and verification.Provertrait forCommitteeChangeProverthat is the prover dedicated for the committee change program.Related issues
Closes #65